Bug Films Linked By Actors....Images not displaying

 
  • Created:over 1 year ago
  • Modified:over 1 year ago by chip
  • Status:fixed
  • Owner:chip
  • Milestone:Apollo SP1
no supporters

When I select an actor say Bruce Willis in the actors part of the film sypnosis to see what other films there in I only see the film name and not the cover art, is this meant to happen or should the film art display??

apollo-sp1 actors
 
history
votes newest oldest
 
  • Created:over 1 year ago
0 I found this helpful 0 This is not helpful

This happens if Banners are set to be shown in the View Menu.

I guess it is actually a bug.

 
link | history
 
  • Created:over 1 year ago
  • Modified:over 1 year ago
0 I found this helpful 0 This is not helpful

Changing to a bug so it may get some attention but not confirming until this has been decided to not be by design for some reason

 
link | history
 
  • Created:over 1 year ago
0 I found this helpful 0 This is not helpful

OK Thanks chip….

 
link | history
  • @Jasoon ,did turning off banners in View Menu fix this for you? – chip over 1 year ago
  • Chip ,banners are now disabled and it works like a dream….thanks chip – Jasoon over 1 year ago
 
  • Created:over 1 year ago
  • Modified:over 1 year ago
0 I found this helpful 0 This is not helpful

Tested in default and diamond

It is very easily replicated; just click on a movie artist with “Show Banners” enabled and the movies he/she is in will have no covers displayed. Don’t show banners and the covers appear again.

I think movies never have Banners so if type is movie then maybe toggling show banners should be greyed out or changed to have no effect.

The inconsistency is that the covers only disappear in Thumb and Poster views, in Thumb Strip and coverflow they remain visible
Edit: This is because these views do not support Banners

However it may be that some themes (chocolate – at least in early experimental form pre apollo) have used Banners as placeholders for ClearLogos for movies and so this may make things more complicated..

Summary
In a way this is logical behaviour – If you select to show banners the cover is hidden but as movies do not have banners no banner is shown.

It could be improved though and made less confusing, perhaps by greying out the option to Show Banners for movies.

However that may impact on theme devs who are using or may wish to use the empty Banner placeholders for Clear Logo support.

Perhaps the theme devs could let us know what they think is best. and then this could be changed to a feature request to improve handling of Banners in View Menu

 
link | history
 
  • Created:over 1 year ago
0 I found this helpful 0 This is not helpful

I just pushed a change to core that will return the primary image if banners are selected but the item has no banner. This will solve this particular issue. However, it could create some other strange side-effects. For instance, I just tried it for Kiefer and, because some items have banners and banners are selected, the view squishes all the art to a banner aspect ratio.

Chip, try it out with trunk and see which you think is the better option.

 
link | history
  • I just tried out your changes ebr and it does work well apart from the “Kiefer Effect” I would say your fix is an improvement because the “Kiefer Effect” is a rarer occurrence than having banners enabled and covers missing for all movies. The ideal solution if it is possible would be to say that if list contains an item with no banner temporarily set Show Banners to false. – chip over 1 year ago